[Marble-devel] Review Request 124605: Clear button and busy indicator for search field
Dennis Nienhüser
dennis at nienhueser.de
Fri Aug 7 13:41:46 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124605/
-----------------------------------------------------------
(Updated Aug. 7, 2015, 1:41 p.m.)
Status
------
This change has been marked as submitted.
Review request for Marble.
Changes
-------
Submitted with commit 4d58ee7b64254146d282b34aa5f5e61898703455 by Dennis Nienhüser to branch master.
Repository: marble
Description
-------
Some minor improvements for the search field:
- add a clear button
- add a busy indicator
- restrict width to a maximum width to avoid that it spans the full screen in landscape mode or on large screens (e.g. tablets)
The buttons (including the existing search button) are rendered inside the search input field for a nicer look. The busy indicator uses a custom style because the default Qt implementation fails to adjust its size on Android.
See http://nienhueser.de/marble/marble-android-search-ui.mp4 for a screencast. The video stutters a bit, my device is too slow to record a screencast in realtime. A screenshot is attached.
Diffs
-----
src/apps/marble-maps/SearchField.qml 5136749
src/apps/marble-maps/MarbleMaps.qrc 2978e72
data/svg/busy_indicator.svg PRE-CREATION
src/apps/marble-maps/Search.qml 9b712c8
src/apps/marble-maps/FlatButton.qml PRE-CREATION
data/android/drawable-xxxhdpi/busy_indicator.png PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124605/diff/
Testing
-------
Tested on a Nexus 4.
File Attachments
----------------
Search Field on a Nexus 4
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/03/937e7b4a-a433-4724-b7e2-ac3b6213fae2__android-search-ui.png
Thanks,
Dennis Nienhüser
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150807/2d632a73/attachment.html>
More information about the Marble-devel
mailing list