[Marble-devel] Review Request 124519: Jump to current location button for Marble Maps

[Dennis Nienhüser]

> On Aug. 1, 2015, 9:09 a.m., Dennis Nienhüser wrote:
> > src/apps/marble-maps/IndicatorCircularButton.qml, line 46
> > <https://git.reviewboard.kde.org/r/124519/diff/3/?file=389019#file389019line46>
> >
> >     Help me with this one.
> >     
> >     ```
> >       Screen.pixelDensity * 9 * 1.41
> >     = root.diameter * sqrt(2)
> >     = sqrt(root.diameter*root.diameter*2)
> >     = sqrt(r.d*r.d+r.d*.r.d)
> >     ```
> >     So this is the length of the diagonal of the square with side length root.diameter. Are you trying to square the circle? :-)
> >     
> >     The effect is that you get some kind of automatic margins to the screen bottom right, but I'd prefer doing that the classic way. So width should be root.diameter and in MainScreen.qml where this item is created let's specify explicit margins to the right and bottom. Then we can also use a larger margin to the bottom to avoid an overlap with the license text (I enabled that one yesterday, you might have to update to latest master to see it).
> 
> Gábor Péterffy wrote:
>     I think this is needed, because I just want to be sure that the indicator can point to every direction without problem. (And for this the Item must be at least root.diameter * sqrt(2))

Indeed, you're right.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124519/#review83273
-----------------------------------------------------------


On Aug. 2, 2015, 3:36 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124519/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2015, 3:36 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch introduces the CircleButton qml type. Based on this there is a button now which navigates the map at the current position.
> 
> 
> Diffs
> -----
> 
>   data/android/drawable-xxxhdpi/gps_not_fixed.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/marblelogo.png bf462f7608169f70cc014d8da1e0ad86e11bed15 
>   src/apps/marble-maps/BoxedText.qml PRE-CREATION 
>   src/apps/marble-maps/CircularButton.qml PRE-CREATION 
>   src/apps/marble-maps/MainScreen.qml ce36f04c61764c7d813608f3bb7aeb671731c5a4 
>   src/apps/marble-maps/MarbleMaps.qrc 2978e72c2fd12fe8435cfb3d5e5559982b41b110 
>   src/apps/marble-maps/PositionButton.qml PRE-CREATION 
>   src/lib/marble/declarative/MarbleQuickItem.h cca329761f23cd72315df2d359166a2cbfa8056c 
>   src/lib/marble/declarative/MarbleQuickItem.cpp 28f599c3b51c7bf993e40c6c97265f351fe02f17 
>   src/plugins/positionprovider/qtpositioning/QtPositioningPositionProviderPlugin.cpp 1a11d67fba96f328a0a5aba7545fa4e93c597964 
>   data/android/drawable-xxxhdpi/backdrop.png PRE-CREATION 
>   data/android/drawable-xxxhdpi/gps_fixed.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124519/diff/
> 
> 
> Testing
> -------
> 
> It seems my distance or angle functions are not working well, the almost always provide false data after some panning (my position is sometimes start to change when I am panning on the map, strange thing: the position marker also starts to go to an other place like it is fixed to the screen, but the map moves under it sometimes when I am penning and it is not jumping back to its place.)
> 
> 
> File Attachments
> ----------------
> 
> gps_not_fixed.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/35409caf-2dbd-4fc4-b495-43fe1d8e4279__gps_not_fixed.png
> gps_fixed.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/019abdbb-80cf-4935-8d6d-0c3e6927d2b3__gps_fixed.png
> marblelogo.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/ebaa4d45-b337-4e42-8a23-a73e2d88ddca__marblelogo.png
> backdrop.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/dacf5958-7270-40c4-9031-243350a80de8__backdrop.png
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150802/c3c05a38/attachment.html>