[Marble-devel] Review Request 123181: Added Right placement for labels and placemark sorting

Adam Dabrowski adabrowski at piap.pl
Tue Apr 14 08:26:19 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated April 14, 2015, 8:26 a.m.)


This change has been marked as submitted.

Review request for Marble.


Submitted with commit f397ec286f7d4b085fb88cb117d967e6b5a4fb24 by Torsten Rahn on behalf of Adam Dabrowski to branch master.

Repository: marble


-Added Right position for placemark labels. Up to 7 positions are available for labels if placemarks overlap.
-Added sorting of placemarks before layouting. Without this there would be labels "jumping" around as several moving placemarks overlap (now they are drawn in the same order and there is no jumping). Cost of sorting is miniscule compared to other operations performed when layouting.
-Refactored code for checking if layout space is already occupied


  src/lib/marble/PlacemarkLayout.cpp 6c0af30 
  src/lib/marble/geodata/data/GeoDataLabelStyle.h 046f7bc 
  src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 5949c7d 

Diff: https://git.reviewboard.kde.org/r/123181/diff/


Displayed 1, 2, 3 and 7+ items.
Checked for no flickering.


Adam Dabrowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150414/228a9cfe/attachment.html>

More information about the Marble-devel mailing list