[Marble-devel] Review Request 123330: Fixed a bug with the manual resizing of GroundOverlayFrame, where the user could invert the North-South and East-West properties.

Torsten Rahn tackat at kde.org
Sat Apr 11 14:17:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123330/#review78811
-----------------------------------------------------------


As discussed on IRC: The East-West behavior is intended (apart from the GroundOverlayFrame that should go the same way as the GroundOverlay). The North/South implementation should allow for inversion but should save the northern and southern in reverse :-)

- Torsten Rahn


On April 11, 2015, 1:12 nachm., Dávid Kolozsvári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123330/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 1:12 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> It was possible while resizing manually the GroundOverlayFrame in edit mode todrag the top(north) edge of the frame below the bottom(south) edge or vice-versa for the other edges too.
> 
> This should not be allowed and this simple patch corrects it.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/GroundOverlayFrame.cpp 7a61a05 
> 
> Diff: https://git.reviewboard.kde.org/r/123330/diff/
> 
> 
> Testing
> -------
> 
> Testing was done by me.
> 
> 
> Thanks,
> 
> Dávid Kolozsvári
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150411/aaf3bc79/attachment.html>


More information about the Marble-devel mailing list