[Marble-devel] Review Request 123322: Improved placemark sorting to make layouting stable with placemarks on same zoomLevel

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123322/#review78801
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On April 10, 2015, 11:26 vorm., Adam Dabrowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123322/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 11:26 vorm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Sorting takes place after joining placemarks from all relevant tiles. The order is:
> 1) zoomLevel (placemarks were already sorted by zoomLevel before this patch)
> 2) popularity
> 3) pointer value
> This prevent cases like label flickering for same zoomLevel placemarks that are close to each other and moving.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/PlacemarkLayout.cpp 6c0af30 
> 
> Diff: https://git.reviewboard.kde.org/r/123322/diff/
> 
> 
> Testing
> -------
> 
> Did testing and debugging to confirm that the order is exactly as intended. No unit tests are provided.
> 
> 
> Thanks,
> 
> Adam Dabrowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150411/d2ba5bbe/attachment.html>