[Marble-devel] Review Request 123181: Added Right placement for labels and placemark sorting

[Adam Dabrowski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123181/
-----------------------------------------------------------

(Updated April 10, 2015, 7:48 a.m.)


Review request for Marble.


Changes
-------

Removed sorting (it will come in a separate patch as it is different fix altogether)


Repository: marble


Description
-------

-Added Right position for placemark labels. Up to 7 positions are available for labels if placemarks overlap.
-Added sorting of placemarks before layouting. Without this there would be labels "jumping" around as several moving placemarks overlap (now they are drawn in the same order and there is no jumping). Cost of sorting is miniscule compared to other operations performed when layouting.
-Refactored code for checking if layout space is already occupied


Diffs (updated)
-----

  src/lib/marble/PlacemarkLayout.cpp 6c0af30 
  src/lib/marble/geodata/data/GeoDataLabelStyle.h 046f7bc 
  src/lib/marble/geodata/graphicsitem/GeoLineStringGraphicsItem.cpp 5949c7d 

Diff: https://git.reviewboard.kde.org/r/123181/diff/


Testing
-------

Displayed 1, 2, 3 and 7+ items.
Checked for no flickering.


Thanks,

Adam Dabrowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150410/4afd2943/attachment-0001.html>