[Marble-devel] Review Request 123304: Bounded textures support (not spanning the whole globe)

Torsten Rahn tackat at kde.org
Thu Apr 9 14:10:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123304/#review78711
-----------------------------------------------------------


I like the concept since it also allows to limit inclusion of a certain layer (even if it's fully available like OSM) to a certain area on the globe.

- Torsten Rahn


On April 9, 2015, 9:22 vorm., Adam Dabrowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123304/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 9:22 vorm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Before this patch, there is an assumption that every texture layer spans the whole globe. Tiles are searched on all previous levels in TileLoader for each geo texture, while it can be the case that the texture layer only spans in certain area (like aerial photos of a certain city). It is both ineffective and unnecessary.
> 
> The patch allows for textures that are bounded by a specified latlon box. With these patch, bounding box can be set for dynamic textures. Additional support and coding for dgml tags parsing should follow.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MergedLayerDecorator.cpp d4652e4 
>   src/lib/marble/geodata/scene/GeoSceneTextureTile.h 5c53779 
>   src/lib/marble/geodata/scene/GeoSceneTextureTile.cpp 6662368 
> 
> Diff: https://git.reviewboard.kde.org/r/123304/diff/
> 
> 
> Testing
> -------
> 
> Displayed a bounded texture, tested for backwards compability.
> 
> 
> Thanks,
> 
> Adam Dabrowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150409/733f5789/attachment-0001.html>


More information about the Marble-devel mailing list