[Marble-devel] Review Request 123204: Extension of MarbleQuickItem API

[Adam Dabrowski]

> On April 2, 2015, 6:29 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/MarbleQuickItem.h, line 34
> > <https://git.reviewboard.kde.org/r/123204/diff/1/?file=359674#file359674line34>
> >
> >     Should there be a corresponding `Q_PROPERTY(int zoom READ zoom WRITE setZoom)` line also? Maybe also a corresponding `NOTIFY zoomChanged` signal.

I am wondering how to share properties between our widget and quickitem classes. There are plenty of properties in MarbleWidget right now that could/should also be in MarbleQuickItem. The only solution that I can think of now involves virtual inheritance of QObject in a common "property/view" class (I know it's used in Qt, but I still don't like the concept). What do you think? 

If you agree that all properties should be shared, then I suggest that it shouldn't be a part of this patch.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123204/#review78418
-----------------------------------------------------------


On April 1, 2015, 6:58 a.m., Adam Dabrowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123204/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 6:58 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added zoom in, center on a box, input handler, and layers event filter interface.
> Also, updated my email address (added company address).
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleQuickItem.h 41e20bb 
>   src/lib/marble/MarbleQuickItem.cpp 9403d13 
> 
> Diff: https://git.reviewboard.kde.org/r/123204/diff/
> 
> 
> Testing
> -------
> 
> Using every part of this api (center on a box for overview and tracking of several placemarks, layers event filter for local map, etc).
> 
> 
> Thanks,
> 
> Adam Dabrowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150407/0b5007db/attachment.html>