[Marble-devel] Review Request 123202: Dynamic adding and removing of texture layers

Adam Dabrowski adabrowski at piap.pl
Tue Apr 7 07:25:23 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated April 7, 2015, 7:25 a.m.)

Review request for Marble.


Applied review suggestions

Repository: marble


TextureLayer class was created based on parsing the .dgml content only. With this patch, MarbleMap API has been extended to allow a dynamic updates of texture layer (i.e. from the qml form-like interface, by pointing to a source directory and reading/inputting some parameters, by pointing to a geotiff and making tiles on the fly etc.). Theses custom textures are then added to static texture list and displayed.

Diffs (updated)

  src/lib/marble/MarbleMap.h 260d46b 
  src/lib/marble/MarbleMap.cpp 13becfc 
  src/lib/marble/layers/TextureLayer.h fed6167 
  src/lib/marble/layers/TextureLayer.cpp 9d8976f 

Diff: https://git.reviewboard.kde.org/r/123202/diff/


Works well on my machine, tested by using for about 3-4 months now. Tested with 1, 2 and 3 dynamic texture layers (based on aerial photos).


Adam Dabrowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150407/14ed1811/attachment.html>

More information about the Marble-devel mailing list