[Marble-devel] Review Request 123259: Added manual rotation to the GroundOverlayFrame in edit mode.

[Dávid Kolozsvári]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123259/
-----------------------------------------------------------

(Updated April 5, 2015, 9:17 p.m.)


Review request for Marble.


Changes
-------

Corrected the isssues pointed out by Torsten Rahn.


Repository: marble


Description
-------

Until now it wasn't possible to rotate the GroundOverlayFrame manually, only from it's properties menu, setting the angle in a spinbox.
This patch introduces a user-friendly manual rotation in edit mode, as well as new icons(thanks to Torsten Rahn) which are shown as handles around it's edges and corners.
Also, a bug was fixed in this patch: the GroundOverlayFrame wasn't able to capture the mouse events that occured outside of it's regions while a controlpoint(handle) was grabbed.


Diffs (updated)
-----

  data/CMakeLists.txt 7b96438 
  data/bitmaps/editarrows/arrow-diagonal-topleft-active.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-diagonal-topleft.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-diagonal-topright-active.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-diagonal-topright.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-horizontal-active.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-horizontal.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-rotation-bottomleft-active.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-rotation-bottomleft.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-rotation-bottomright-active.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-rotation-bottomright.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-rotation-topleft-active.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-rotation-topleft.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-rotation-topright-active.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-rotation-topright.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-vertical-active.png PRE-CREATION 
  data/bitmaps/editarrows/arrow-vertical.png PRE-CREATION 
  src/plugins/render/annotate/AnnotatePlugin.cpp 45e8746 
  src/plugins/render/annotate/GroundOverlayFrame.h 194ade5 
  src/plugins/render/annotate/GroundOverlayFrame.cpp c27eabd 
  src/plugins/render/annotate/SceneGraphicsItem.h c59340e 

Diff: https://git.reviewboard.kde.org/r/123259/diff/


Testing
-------

Testing was done by me and it works fine.


Thanks,

Dávid Kolozsvári

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150405/7bdcdebc/attachment.html>