[Marble-devel] Review Request 123252: FormattedTextWidget: textColorButton fix.

Calin Cruceru crucerucalincristian at gmail.com
Sat Apr 4 11:17:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123252/#review78479
-----------------------------------------------------------

Ship it!


LGTM.

- Calin Cruceru


On April 4, 2015, 1:57 p.m., Constantin Mihalache wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123252/
> -----------------------------------------------------------
> 
> (Updated April 4, 2015, 1:57 p.m.)
> 
> 
> Review request for Marble, Calin Cruceru and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Bugs:
> #1 The textColorButton didn't behave like the other buttons surrounding it (if the window is resized, this does not enter the dropdown list).
> #2 Resized EditPlacemarkDialog window a bit :)
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/EditPlacemarkDialog.ui b40c7ac 
>   src/lib/marble/FormattedTextWidget.cpp 1da3813 
>   src/lib/marble/FormattedTextWidget.ui 2082275 
> 
> Diff: https://git.reviewboard.kde.org/r/123252/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Constantin Mihalache
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150404/9b5a1bf1/attachment.html>


More information about the Marble-devel mailing list