[Marble-devel] Review Request 122849: Implemented the scale feature (for icons and labels) when adding placemarks via the Edit Mode

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122849/#review78427
-----------------------------------------------------------



src/lib/marble/EditPlacemarkDialog.ui (line 463)
<https://git.reviewboard.kde.org/r/122849/#comment53661>

    We really need to fix our icon resource paths. Everytime we reference ../apps/.. icons in a lib/marble/ class we break external apps (i.e. they cannot access and display that icon).
    
    As that is a general and known problem it can be kept apart of this review request.



src/lib/marble/geodata/data/GeoDataIconStyle.h (line 31)
<https://git.reviewboard.kde.org/r/122849/#comment53662>

    Memory leak. Use a simple
    `static const QSize s_maximumIconSize = QSize( 100, 100 );`
    instead, same in the line below.



src/lib/marble/geodata/data/GeoDataIconStyle.cpp (line 199)
<https://git.reviewboard.kde.org/r/122849/#comment53663>

    Use curly brackets even for one-liners, see https://techbase.kde.org/Policies/Kdelibs_Coding_Style



src/lib/marble/geodata/data/GeoDataLabelStyle.cpp (line 145)
<https://git.reviewboard.kde.org/r/122849/#comment53664>

    why not smaller than 1? I'd rather expect not smaller than 0?


- Dennis Nienhüser


On March 25, 2015, 9:42 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122849/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 9:42 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The feature was disabled(greyed out) and it didn't work. Now drawing the placemark keeps account of the scale member.
> 
> I have one issue though:
> I didn't really know where to place a constant for a maximum icon size( limiting the user ) so I could use your opinion.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/EditPlacemarkDialog.ui e17bf14 
>   src/lib/marble/PlacemarkLayout.cpp 6c0af30 
>   src/lib/marble/VisiblePlacemark.cpp d57dcb0 
>   src/lib/marble/geodata/data/GeoDataIconStyle.h 4afb115 
>   src/lib/marble/geodata/data/GeoDataIconStyle.cpp 5385cd1 
>   src/lib/marble/geodata/data/GeoDataLabelStyle.h 046f7bc 
>   src/lib/marble/geodata/data/GeoDataLabelStyle.cpp 1ec0c78 
> 
> Diff: https://git.reviewboard.kde.org/r/122849/diff/
> 
> 
> Testing
> -------
> 
> works for me.
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150403/9783a02c/attachment-0001.html>