[Marble-devel] Review Request 123180: Improved ground overlays

Adam Dabrowski adabrowski at piap.pl
Thu Apr 2 18:40:35 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated April 2, 2015, 6:40 p.m.)


This change has been marked as submitted.

Review request for Marble.


Submitted with commit ff2e6ee3a3de0be70f45648d28edd1ce1b904e55 by Dennis Nienhüser on behalf of Adam Dabrowski to branch master.

Repository: marble


Improved ground overlays: performance, transluscency, visibility

-Performance improved by replacing object construction in critical part of the code with static calls
-Added transluscency based on alpha of pixels in overlay icon
-Added testing for global visibility before rendering overlay


  src/lib/marble/MergedLayerDecorator.cpp fd3b6e9 
  src/lib/marble/geodata/data/GeoDataLatLonBox.h 5505090 
  src/lib/marble/geodata/data/GeoDataLatLonBox.cpp 5dd7834 

Diff: https://git.reviewboard.kde.org/r/123180/diff/


Ran with several images of ground overlays, tested performance with QElapsedTimer. 

All three aspect work and the performance is improved almost 3x on my machine - tested by rotating and moving the overlay around.


Adam Dabrowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150402/95fa447c/attachment-0001.html>

More information about the Marble-devel mailing list