[Marble-devel] Review Request 123141: Extends the precision node editor (the one from previous patch, for polygons) to polylines

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123141/#review78409
-----------------------------------------------------------


I just found a few bugs while using the EditPolygonDialog and EditPolylineDialog:

* The Longitude has latitude units and the latitude has longitude units in the Delegate
* Longitude can not be increased beyond 90° and Latitude can be increased beyond 90° which shouldn't be possible
* Bernhard Beschow reported that the delegate doesn't respect his Decimal notation settings.
* Keyboard input on selection doesn't work properly for the EditPolygonDialog case.

- Torsten Rahn


On März 26, 2015, 7:05 nachm., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123141/
> -----------------------------------------------------------
> 
> (Updated März 26, 2015, 7:05 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Turned NodeItemDelegate into a more generic delegate, that deals with both EditPolygonDialog's and EditPolylineDialog's ListViews.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/NodeItemDelegate.cpp bed78aa 
>   src/plugins/render/annotate/EditPolygonDialog.cpp c647e6b 
>   src/plugins/render/annotate/EditPolylineDialog.cpp a99a3e9 
>   src/plugins/render/annotate/NodeItemDelegate.h aaa8084 
> 
> Diff: https://git.reviewboard.kde.org/r/123141/diff/
> 
> 
> Testing
> -------
> 
> works for me
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150402/135c4778/attachment.html>