[Marble-devel] Review Request 123193: CMake fix for empty prefix string
Adam Dabrowski
adabrowski at piap.pl
Wed Apr 1 13:38:19 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123193/
-----------------------------------------------------------
(Updated April 1, 2015, 1:38 p.m.)
Status
------
This change has been marked as submitted.
Review request for Marble.
Repository: marble
Description
-------
While in common use the CMAKE_INSTALL_PREFIX will be something like /usr/local, I had the need to fix this as we are deploying marble on embedded system in a highly customized way.
The new version is strictly better as it works the same with non-empty prefixes but it also works with empty prefix.
Note that this might apply to other instances of where "STRING(LENGTH ..." is used
Diffs
-----
src/CMakeLists.txt 6c4cc7f
Diff: https://git.reviewboard.kde.org/r/123193/diff/
Testing
-------
I've been building with this cmake since three months or so, both with empty and /usr/local prefixes.
Thanks,
Adam Dabrowski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150401/41d6eb6c/attachment.html>
More information about the Marble-devel
mailing list