[Marble-devel] Review Request 120030: Multiple sessions
Gábor Péterffy
peterffy95 at gmail.com
Thu Sep 18 08:33:31 UTC 2014
> On szept. 9, 2014, 9:59 du, Bernhard Beschow wrote:
> > Can you please elaborate a bit on the "session" and why it is needed? This way we (as in I) have a chance to judge about the patch. Thx!
> >
> > I'm looking forward for having panorama support in Marble.
>
> Gábor Péterffy wrote:
> A session basically contains the following things:
> - the model containing the data
> - the map containig the layers, etc...
> - the popup layer and the routing layer
>
> Important to store these because it would be very annoying when you open a panorama and after that everything would be just wiped out like when Marble is opened. So this is very important to improve the user experience. And of course as I wrote in the description this patch also opens a lot of possibilities.
>
> Bernhard Beschow wrote:
> Why not simply display another MarbleWidget on top? Why was 119538 discarded? What did I miss?
Maybe this conversation gives the answer for you: http://pastebin.com/8f56PcR7
So, we don't want to create a complete UI for a session, because we maybe want use it just in the background.
- Gábor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120030/#review66151
-----------------------------------------------------------
On szept. 4, 2014, 5 du, Gábor Péterffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120030/
> -----------------------------------------------------------
>
> (Updated szept. 4, 2014, 5 du)
>
>
> Review request for Marble and Torsten Rahn.
>
>
> Repository: marble
>
>
> Description
> -------
>
> Adds the ability to save sessions at runtime and start a new one and later return to the previous one.
>
> -This could be improved with adding the ability to change between sessions without closing any.
> -Also it could be improved/used up to create an undo ability (Maybe with QUndo?)
> -It could be used up to support high resolution printing with creating a session in the background
>
>
> Diffs
> -----
>
> src/lib/marble/SessionManager.h PRE-CREATION
> src/lib/marble/SessionManager.cpp PRE-CREATION
> src/lib/marble/CMakeLists.txt 482a241a4e61fc26cede3b9140cbd320016d0ac2
> src/lib/marble/MarbleAbstractPresenter.h 9518e7e77797d026d78d4740a8c813c943868883
> src/lib/marble/MarbleAbstractPresenter.cpp ecb29cb90826c421ef90f423466f344bdbb498ac
> src/lib/marble/MarbleWidget.cpp 75d2d8f63021e5c278f5e57e30f03f093b068943
>
> Diff: https://git.reviewboard.kde.org/r/120030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gábor Péterffy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140918/40a3f111/attachment.html>
More information about the Marble-devel
mailing list