[Marble-devel] Review Request 119982: FileWatcher: honor disk cache size

[Thibaut Gridel]

> On Aug. 31, 2014, 3:09 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/FileStorageWatcher.cpp, line 123
> > <https://git.reviewboard.kde.org/r/119982/diff/1/?file=308041#file308041line123>
> >
> >     from QFileInfo docs I assume calling endsWith is identical to calling operator==, no?

That would be assuming that filename has only one dot.
I should be using ssuffix() anyway


- Thibaut


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119982/#review65580
-----------------------------------------------------------


On Aug. 28, 2014, 8:57 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119982/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 8:57 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Current code stops are identifying localDir()/maps as dangerous to handle.
> 
> This implementation gets a lot simpler, trying to remove oldest map tiles below level 4 to keep at disk cache size value.
> 
> The internal weirdness has been kept (delete in batches, define a soft limit...) until some more cleanup is done.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/FileStorageWatcher.h cf1ae64 
>   src/lib/marble/FileStorageWatcher.cpp 8706e71 
>   src/lib/marble/MarbleModel.cpp 5f1b88a 
> 
> Diff: https://git.reviewboard.kde.org/r/119982/diff/
> 
> 
> Testing
> -------
> 
> Basic functionnality is here, if you don't want your precious tiles to be dropped you may toggle writeable bit off.
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140906/22796f2d/attachment-0001.html>