[Marble-devel] Review Request 120797: Proper visibility of string in Configure Routing Profile (Monav service).

[Mihir Thakkar]

> On Oct. 28, 2014, 3:48 a.m., Dennis Nienhüser wrote:
> > I opened the .ui file in designer-qt4 and it seems to me that both the "Configure" and the "Install New" tab lack a layout (e.g. a grid layout) by accident. They can easily be added in Qt Designer and previewing the widget with Ctrl+R there looks good. Can you test whether that works as well when compiling it and running Marble with it?

I have updated the .ui file, adding grid layout to the "Configure" and the "Install New" tab. I've uploaded the revised patch.
And yes, it works well when compiling and running Marble.


- Mihir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120797/#review69235
-----------------------------------------------------------


On Oct. 28, 2014, 9:19 a.m., Mihir Thakkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120797/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 9:19 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 339895
>     http://bugs.kde.org/show_bug.cgi?id=339895
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> shifting the position of m_transportTypeComboBox widget so that the string in Label_2: QLabel is fully visible.
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/monav/MonavConfigWidget.ui 4d7910c 
> 
> Diff: https://git.reviewboard.kde.org/r/120797/diff/
> 
> 
> Testing
> -------
> 
> This works well when compiling and running Marble.
> 
> 
> Thanks,
> 
> Mihir Thakkar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141028/98f99c11/attachment.html>