[Marble-devel] Review Request 118203: A presenter class for marble widget in anticipation of Qt Quick 2.0 port and basic QQuickItem class

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118203/#review58683
-----------------------------------------------------------



examples/cpp/marbleQuick2/main.cpp
<https://git.reviewboard.kde.org/r/118203/#comment40843>

    Copyright header missing



src/lib/marble/MarbleAbstractPresenter.h
<https://git.reviewboard.kde.org/r/118203/#comment40842>

    Coypright header missing. Please copy over from MarbleWidget and add your name as well



src/lib/marble/MarbleAbstractPresenter.cpp
<https://git.reviewboard.kde.org/r/118203/#comment40841>

    Coypright header missing. Please copy over from MarbleWidget and add your name as well



src/lib/marble/MarbleQuickItem.h
<https://git.reviewboard.kde.org/r/118203/#comment40839>

    Coypright header missing



src/lib/marble/MarbleQuickItem.h
<https://git.reviewboard.kde.org/r/118203/#comment40845>

    unused? if used, it should be in the private class? Same below.



src/lib/marble/MarbleQuickItem.cpp
<https://git.reviewboard.kde.org/r/118203/#comment40840>

    Coypright header missing



src/lib/marble/MarbleQuickItem.cpp
<https://git.reviewboard.kde.org/r/118203/#comment40844>

    m_marblePresenter or m_presenter


- Dennis Nienhüser


On May 28, 2014, 6:19 a.m., Adam Dabrowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118203/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 6:19 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> A first step to port Marble to Qt Quick 2.0 
> Extracted most of QWidget-independent implementation code from MarbleWidget into MarbleAbstractPresenter
> Adjusted MarblePhysics as an example of a port for a class that formerly used MarbleWidget
> Wrote a stub QQuickItem class. This was tested with QML 2.0 and works (displays maps and reacts to keyboard input).
> 
> Still a work in progress, but a chunk that can be pushed without breaking anything.
> 
> 
> Diffs
> -----
> 
>   examples/cpp/CMakeLists.txt 98a1ae4 
>   examples/cpp/marbleQuick2/CMakeLists.txt PRE-CREATION 
>   examples/cpp/marbleQuick2/CMakeLists.txt.external PRE-CREATION 
>   examples/cpp/marbleQuick2/Readme.txt PRE-CREATION 
>   examples/cpp/marbleQuick2/main.cpp PRE-CREATION 
>   examples/cpp/marbleQuick2/main.qml PRE-CREATION 
>   src/lib/marble/CMakeLists.txt 5b4a0ee 
>   src/lib/marble/MarbleAbstractPresenter.h PRE-CREATION 
>   src/lib/marble/MarbleAbstractPresenter.cpp PRE-CREATION 
>   src/lib/marble/MarblePhysics.h 8559809 
>   src/lib/marble/MarblePhysics.cpp 9c4b112 
>   src/lib/marble/MarbleQuickItem.h PRE-CREATION 
>   src/lib/marble/MarbleQuickItem.cpp PRE-CREATION 
>   src/lib/marble/MarbleWidget.cpp 10b466e 
> 
> Diff: https://git.reviewboard.kde.org/r/118203/diff/
> 
> 
> Testing
> -------
> 
> Tested using attached app.
> Also did a regression tests for MarbleWidget (simple ones)
> 
> 
> Thanks,
> 
> Adam Dabrowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140529/26f22248/attachment.html>