[Marble-devel] Review Request 118240: Functionality for Edit buttons of Wait items in the Tour Playlist

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118240/#review58593
-----------------------------------------------------------



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/118240/#comment40782>

    There shouldn't be abbreviations in UI strings. So either "Number of seconds to wait:" or something shorter like "Wait duration:"



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/118240/#comment40783>

    Should be possible to use 
    m_editorWidgets[ persistentIndex ] = spinBox;
    directly and avoid the intermediate QWidget* variable.


- Dennis Nienhüser


On May 22, 2014, 8:41 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118240/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 8:41 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch lets the user change the value of the Wait items of the Tour Playlist by providing a spin-box for increasing/decreasing it, when the Edit button is clicked
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.h 103740b 
>   src/lib/marble/TourWidget.cpp b94b307 
>   src/lib/marble/graphicsview/WidgetGraphicsItem.cpp 246e8fd 
> 
> Diff: https://git.reviewboard.kde.org/r/118240/diff/
> 
> 
> Testing
> -------
> 
> Works like a charm :)
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140527/db4fa0b5/attachment.html>