[Marble-devel] Review Request 118190: Functionality for Edit buttons of FlyTo and TourControl items of Tour Playlist

Sanjiban Bairagya sanjiban22393 at gmail.com
Mon May 19 17:55:06 UTC 2014



> On May 19, 2014, 8:51 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/TourWidget.h, line 103
> > <https://git.reviewboard.kde.org/r/118190/diff/1/?file=273370#file273370line103>
> >
> >     Where is it used?

Sorry, it is not used anywhere. I am removing it


- Sanjiban


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118190/#review58156
-----------------------------------------------------------


On May 18, 2014, 5:07 a.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118190/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 5:07 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch implements the following unctionalities:
> - when an user clicks on the Edit button of a FlyTo element, then it will prompt the user to make the map's focus point the new point which he/she wants to make the new coordinates of the element. Clicking on Edit again will update and save this new coordinate.
> - when an user clicks on the Edit button of a TourControl element, it will show two radio buttons, and the user has select one of them. When he clicks on any one of "Play" or "Pause", the radio buttons disappear and the changes get reflected on the playlist immediately. The "Edit" button in this case is a toggle button between Change/Not-Change
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.h c38d620 
>   src/lib/marble/TourWidget.cpp aff7e99 
> 
> Diff: https://git.reviewboard.kde.org/r/118190/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140519/dc19b90f/attachment.html>


More information about the Marble-devel mailing list