[Marble-devel] Review Request 118040: [FIX] Make equality operator in GeoDataFlyTo compare m_view based on nodeType

[Cruceru Calin-Cristian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118040/
-----------------------------------------------------------

(Updated May 7, 2014, 10:53 p.m.)


Review request for Marble.


Repository: marble


Description (updated)
-------

The current implementation of GeoDataFlyTo::operator== compares the m_view's which are GeoDataAbstractView pointers and it was causing some tests to fail after implementing TestGeoDataWriter::saveAndCompareEquality method. It was also caused by the fact that the unit tests for this operator were pretty poorely written.

The implementation I propose checks the nodeType of each m_view (this' and other's) and casts it to GeoDataCamera or GeoDataLookAt according to the check.


Diffs
-----

  src/lib/marble/geodata/data/GeoDataFlyTo.cpp 2ddcad8 

Diff: https://git.reviewboard.kde.org/r/118040/diff/


Testing
-------


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140507/46a4b663/attachment.html>