[Marble-devel] Review Request 118010: Equality operators for Container, Folder and Document

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118010/#review57436
-----------------------------------------------------------

Ship it!


Looks good :)


src/lib/marble/geodata/data/GeoDataContainer.cpp
<https://git.reviewboard.kde.org/r/118010/#comment39959>

    Please add curly brackets.


- Dennis Nienhüser


On May 5, 2014, 8:05 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118010/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 8:05 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 334286
>     http://bugs.kde.org/show_bug.cgi?id=334286
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> - Implemented the equals() method in GeoDataContainer.
> - Added operator== and operator!= to GeoDataFolder and GeoDataDocument.
> - Added a new test unit for GeoDataFolder.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataContainer.h 1ce7cc5 
>   src/lib/marble/geodata/data/GeoDataContainer.cpp c2b9bb7 
>   src/lib/marble/geodata/data/GeoDataDocument.h dadfed3 
>   src/lib/marble/geodata/data/GeoDataDocument.cpp 8a33132 
>   src/lib/marble/geodata/data/GeoDataFolder.h 3c4be04 
>   src/lib/marble/geodata/data/GeoDataFolder.cpp dea78ab 
>   src/lib/marble/geodata/data/GeoDataNetworkLinkControl.cpp 2e9827d 
>   tests/TestEquality.cpp 7773f1b 
> 
> Diff: https://git.reviewboard.kde.org/r/118010/diff/
> 
> 
> Testing
> -------
> 
> Tested with tests/TestEquality and works as expected.
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140506/22100590/attachment.html>