[Marble-devel] Review Request 118011: [FIX] Equality operators for GeoDataPlacemark + Other issues

[Cruceru Calin-Cristian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118011/
-----------------------------------------------------------

(Updated May 6, 2014, 12:16 a.m.)


Review request for Marble.


Changes
-------

I guess this may be the answear to the first issue I mentioned.


Repository: marble


Description
-------

The previous implementation of operator== in GeoDataPlacemark was, as even the documentation said, comparing the 2 private pointers of each instance of the class. I thought that this implementation would be more appropriate, but there are still some issues, especially caused by the m_geometry pointer:
- how should this be compared to the other's m_geometry?
- even though it is not regarded to what for I opened this bug review request, we should think of that //FIXME comment within the GeoDataPlacemark( const GeoDataPlacemark &other ) constructor because I think it will cause problems when we will finish implementing operators== and we will start testing on real .kml files.
- shouldn't m_geometry be deleted within the destructor, since its parent is the current object? I see that it is deleted when set a new one geometry, but not in destructor; maybe I didn't understand this correctly.


Diffs (updated)
-----

  src/lib/marble/geodata/data/GeoDataPlacemark.h bd32b4c 
  src/lib/marble/geodata/data/GeoDataPlacemark.cpp 5df534d 

Diff: https://git.reviewboard.kde.org/r/118011/diff/


Testing
-------


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140505/150ff7f9/attachment-0001.html>