[Marble-devel] Review Request 116878: Fixed bug: 324862 so that the scale bar and map overview does follow the mouse anymore

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116878/#review54528
-----------------------------------------------------------


That works around the problem, because the different initialization logic results in a different order of event filters installed on MarbleWidget: MarbleWidgetInputHandler will not install the event filters anymore in its ctor, but during installPluginEventFilter which is triggered by the layer manager initializing the plugin on its first render attempt. The (simplified) event filter order is then
without the patch: MarbleWidgetDefaultInputHandler => ScaleBar, OverviewMap
with the patch: ScaleBar, OverviewMap => MarbleWidgetDefaultInputHandler

The plugin's eventFilter method is then called before MarbleWidgetDefaultInputHandler does eat the MouseButtonRelease event, which prevents the bug. I'd rather have the original problem solved though, MarbleWidgetDefaultInputHandler should behave in a sane way and not require workarounds.

The following fixes the problem here:
git show -R c4e0678 | sed 's at src/lib/@src/lib/marble/@' | patch -p1
See https://bugs.kde.org/show_bug.cgi?id=242414 as well. The original bug (oxygen doing silly things) does not seem to occur anymore here, so reverting c4e0678 seems ok from my point of view. I'd like to have some other people test it before though.

Everyone, please give the following a try:
# change directory to marble sources
git show -R c4e0678 | sed 's at src/lib/@src/lib/marble/@' | patch -p1
# compile and run marble
# test that dragging the globe does not move the whole window as described in https://bugs.kde.org/show_bug.cgi?id=242414



- Dennis Nienhüser


On March 18, 2014, 5:54 p.m., Abhinav Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116878/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 5:54 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 324862
>     http://bugs.kde.org/show_bug.cgi?id=324862
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Now the info boxes (scale bar and map overview) doesn't follow the mouse.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/mapscale/MapScaleFloatItem.h 4a0f922 
>   src/plugins/render/mapscale/MapScaleFloatItem.cpp ea869bb 
>   src/plugins/render/overviewmap/OverviewMap.h 4c9ada8 
>   src/plugins/render/overviewmap/OverviewMap.cpp ee52f03 
> 
> Diff: https://git.reviewboard.kde.org/r/116878/diff/
> 
> 
> Testing
> -------
> 
> Produces expected results on my system
> 
> 
> Thanks,
> 
> Abhinav Gangwar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140329/8e7a2d5b/attachment-0001.html>