[Marble-devel] Review Request 117022: Added support for schema tags Schema and its child elements.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117022/#review54261
-----------------------------------------------------------



src/lib/marble/geodata/data/GeoDataDocument.cpp
<https://git.reviewboard.kde.org/r/117022/#comment37937>

    Shouldn't this reset the parent here?



src/lib/marble/geodata/data/GeoDataSchema.h
<https://git.reviewboard.kde.org/r/117022/#comment37938>

    setSchemaId?



src/lib/marble/geodata/data/GeoDataSchema.h
<https://git.reviewboard.kde.org/r/117022/#comment37939>

    setSchemaName?



src/lib/marble/geodata/data/GeoDataSchema.h
<https://git.reviewboard.kde.org/r/117022/#comment37940>

    addSimpleField



src/lib/marble/geodata/data/GeoDataSimpleField.h
<https://git.reviewboard.kde.org/r/117022/#comment37942>

    Is it a GeoDataObject really?



src/lib/marble/geodata/data/GeoDataSimpleField.h
<https://git.reviewboard.kde.org/r/117022/#comment37941>

    const QString &



src/lib/marble/geodata/handlers/kml/KmlSimpleFieldTagHandler.cpp
<https://git.reviewboard.kde.org/r/117022/#comment37943>

    Short


- Dennis Nienhüser


On March 24, 2014, 3:41 p.m., Abhinav Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117022/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 3:41 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 332334
>     http://bugs.kde.org/show_bug.cgi?id=332334
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The patch implements support for kml Schema tag and its child elements SimpleField and displayName
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/CMakeLists.txt 69edb65 
>   src/lib/marble/geodata/data/GeoDataDocument.h 5a36a65 
>   src/lib/marble/geodata/data/GeoDataDocument.cpp 575105e 
>   src/lib/marble/geodata/data/GeoDataDocument_p.h 1fd3d7d 
>   src/lib/marble/geodata/data/GeoDataSchema.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataSchema.cpp PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataSimpleField.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataSimpleField.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlDisplayNameTagHandler.cpp 86d18e1 
>   src/lib/marble/geodata/handlers/kml/KmlSchemaTagHandler.cpp c60d28c 
>   src/lib/marble/geodata/handlers/kml/KmlSimpleFieldTagHandler.h 1bea122 
>   src/lib/marble/geodata/handlers/kml/KmlSimpleFieldTagHandler.cpp 2052cc3 
>   src/lib/marble/geodata/parser/GeoDataTypes.h ae12cf1 
>   src/lib/marble/geodata/parser/GeoDataTypes.cpp a4c69e4 
>   src/lib/marble/geodata/writers/kml/KmlDocumentTagWriter.cpp d6da338 
>   src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.h PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlSchemaTagWriter.cpp PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlSimpleFieldTagWriter.h PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlSimpleFieldTagWriter.cpp PRE-CREATION 
>   tests/TestGeoDataWriter.cpp a8230e0 
>   tests/data/schema.kml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/117022/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhinav Gangwar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140327/041fcf69/attachment.html>