[Marble-devel] Review Request 116831: Read/write gx:altitudeMode for KML LookAt tags

[Cruceru Calin-Cristian]

> On March 16, 2014, 1:50 p.m., Dennis Nienhüser wrote:
> > src/lib/marble/geodata/data/GeoDataCamera.cpp, line 47
> > <https://git.reviewboard.kde.org/r/116831/diff/2/?file=254413#file254413line47>
> >
> >     Still needs to be compared for equality, and ideally our test cases would reveal this as a regression ;-)
> >     altitudeMode() == other.altitudeMode()

I'm not sure what you mean by "our test cases would reveal this as a regression". Which more precisely test are you referring to?


- Cruceru


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116831/#review53041
-----------------------------------------------------------


On March 16, 2014, 1:28 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116831/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 1:28 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 332108
>     http://bugs.kde.org/show_bug.cgi?id=332108
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The gx:altitudeMode can now be read from and written to KML files inside the LookAt tag.
> - Moved the altitudeMode getter and setter from GeoDataCamera up to GeoDataAbstractView;
> - Changed KmlaltitudeModeTagHandler and KmlGxAltitudeModeTagHandler to check for GeoDataAbstractView instead of GeoDataCamera;
> - Now the altitude mode in KmlLookAtTagWriter is written just like in KmlCameraTagWriter;
> - Added a <gx:altitudeMode>clampToSeaFloor</gx:altitudeMode> to tests/data/LookAtTest.kml.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataAbstractView.h b136e4f 
>   src/lib/marble/geodata/data/GeoDataAbstractView.cpp ca44659 
>   src/lib/marble/geodata/data/GeoDataCamera.h 2aa2578 
>   src/lib/marble/geodata/data/GeoDataCamera.cpp de5191d 
>   src/lib/marble/geodata/data/GeoDataCamera_p.h 37ced50 
>   src/lib/marble/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp 2968aea 
>   src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.cpp 00785d3 
>   src/lib/marble/geodata/writers/kml/KmlLookAtTagWriter.cpp 046a3cc 
>   tests/data/LookAtTest.kml 60ce73c 
> 
> Diff: https://git.reviewboard.kde.org/r/116831/diff/
> 
> 
> Testing
> -------
> 
> I tested it using tests/TestGeoDataWriter and it works as expected.
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140316/b8576ad8/attachment.html>