[Marble-devel] Review Request 116702: Extend unit test KML files to cover various KML Style tags

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116702/#review52901
-----------------------------------------------------------


This review has been submitted with commit d8bea157f55d72abd762b7a41e69b2a2e7492c2b by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.

- Commit Hook


On March 10, 2014, 11:58 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116702/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 11:58 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331532
>     http://bugs.kde.org/show_bug.cgi?id=331532
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> It was intended to extend the .kml files in tests/data/ to include at least one tag for each with non-default values of BalloonStyle, ColorStyle, IconStyle, LineStyle, ListStyle, PolyStyle. 
> I made few modifications because most of the tags are already covered appropriately, mainly due to this bug I solved: https://bugs.kde.org/show_bug.cgi?id=331766 . This happened maybe because this is an older bug, which has been reassigned. Their coverage can be checked out here: http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/index.html .
> 
> If I misunderstood the requirements for this bug, please tell me and I will continue the work on it.
> 
> 
> Diffs
> -----
> 
>   tests/data/ListStyleTest1.kml a0fc232 
>   tests/data/ListStyleTest2.kml ce29ba2 
>   tests/data/MackyModel.kml 1de8911 
>   tests/data/NetworkLinkDocument.kml 0ea73d1 
> 
> Diff: https://git.reviewboard.kde.org/r/116702/diff/
> 
> 
> Testing
> -------
> 
> I've test it using tests/TestGeoDataWriter and everything works as expected.
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140313/67a17173/attachment.html>