[Marble-devel] Review Request 114915: [ESA SoCIS 2013] Eclipses event reminder dialog with application logic

[Marek Hakala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114915/
-----------------------------------------------------------

(Updated March 12, 2014, 12:08 p.m.)


Review request for Marble, Torsten Rahn and René Küttner.


Changes
-------

Patch update


Repository: marble


Description
-------


Task:
Implement the reminder functionality. There already is a reminder option in the preferences dialog and a user interface for the reminder dialog (EclipsesReminderDialog.ui). However, these are not implemented yet. You could implement the code that reminds the user if an eclipse event occours within the next week and show the dialog. It would also be nice if the user could jump to the eclipse event from the reminder dialog. We also have to make sure the dialog does not appear again and again. The dialog itself should show some information about the event (type, date, time, length etc.)

Solution:
In this task I implemented the filter model and application logic for reminder by the QT's Model/View patterns. I added the facade class for reminder management. This patch adds the ability for remind eclises events in adjustable time period.


Diffs (updated)
-----

  src/plugins/render/eclipses/EclipsesReminderFacade.cpp PRE-CREATION 
  src/plugins/render/eclipses/EclipsesReminderFacade.h PRE-CREATION 
  src/plugins/render/eclipses/EclipsesReminderDialog.ui 5d17519 
  src/plugins/render/eclipses/EclipsesReminderDialog.cpp PRE-CREATION 
  src/plugins/render/eclipses/EclipsesReminderDialog.h PRE-CREATION 
  src/plugins/render/eclipses/EclipsesPlugin.h 5484292 
  src/plugins/render/eclipses/EclipsesPlugin.cpp e20e900 
  src/plugins/render/eclipses/EclipsesModel.cpp 0c251a7 
  src/plugins/render/eclipses/EclipsesModel.h 5196d8d 
  src/plugins/render/eclipses/EclipsesItem.cpp 0148780 
  src/plugins/render/eclipses/EclipsesItem.h cc971e9 
  src/plugins/render/eclipses/EclipsesFilterProxyModel.cpp PRE-CREATION 
  src/plugins/render/eclipses/EclipsesFilterProxyModel.h PRE-CREATION 
  src/plugins/render/eclipses/EclipsesConfigDialog.ui ca25e6f 
  src/plugins/render/eclipses/CMakeLists.txt f650e08 
  src/lib/astro/eclsolar.cpp ac0aa61 
  src/lib/astro/eclsolar.h 5eb567c 

Diff: https://git.reviewboard.kde.org/r/114915/diff/


Testing
-------


Thanks,

Marek Hakala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140312/3d04bd79/attachment.html>