[Marble-devel] Review Request 116644: Bug 331766 - Extend KML unit test coverage of tag writers

[Cruceru Calin-Cristian]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116644/
-----------------------------------------------------------

(Updated March 7, 2014, 9:11 p.m.)


Review request for Marble.


Changes
-------

Solved the problem. :)


Bugs: 331766
    http://bugs.kde.org/show_bug.cgi?id=331766


Repository: marble


Description
-------

Extends the existing .kml unit tests in tests/data and also adds new ones to maximize the test coverage of tag writers.

There is one mention: The test, tests/TestGeoDataWriter fails because of the file tests/data/Tour.kml and I have the following diff: http://paste.kde.org/pksuar839 . I cannot figure out at the moment why it jumps over this tag. Syntactically, my .kml file seems correct, so I think there is a problem in the code ? I will try to find what causes this and I will come back with an update if necessary.


Diffs (updated)
-----

  tests/data/CameraLookAt.kml 8934073 
  tests/data/AltitudeMode.kml 0e90594 
  tests/data/CDATATest.kml a14931e 
  src/lib/marble/geodata/handlers/kml/KmlFlyToModeTagHandler.cpp b993d7e 
  tests/data/Geometries.kml eff3bb1 
  tests/data/ListStyleTest1.kml PRE-CREATION 
  tests/data/ListStyleTest2.kml PRE-CREATION 
  tests/data/ListStyleTest3.kml PRE-CREATION 
  tests/data/ListStyleTest4.kml PRE-CREATION 
  tests/data/ListStyleTest5.kml PRE-CREATION 
  tests/data/LookAtTest.kml PRE-CREATION 
  tests/data/PhotoOverlayInFolder.kml ec4bb3f 
  tests/data/Tour.kml 0f2c044 
  tests/data/Track.kml 2ac0a6e 

Diff: https://git.reviewboard.kde.org/r/116644/diff/


Testing
-------


Thanks,

Cruceru Calin-Cristian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140307/115e7c06/attachment.html>