[Marble-devel] Review Request 116572: Equality operators for GeoDataLatLonQuad, GeoDataLod and GeoDataRegion

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116572/#review52112
-----------------------------------------------------------


Can you please update the patch for latest master? Due to a recent change in TestEquality.cpp it does not apply anymore. Thanks.


tests/TestEquality.cpp
<https://git.reviewboard.kde.org/r/116572/#comment36992>

    Please end the method name with 'Test'


- Dennis Nienhüser


On March 3, 2014, 4:23 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116572/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 4:23 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331673
>     http://bugs.kde.org/show_bug.cgi?id=331673
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added equality operators for GeoDataLatLonQuad, GeoDataLod and GeoDataRegion.
> Added latLonQuadTest(), latLonBoxTest(), latLonAltBox(), lodTest(), regionTest() in TestEquality
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataLatLonAltBox.cpp a7f4225 
>   src/lib/marble/geodata/data/GeoDataLatLonBox.h d884b4a 
>   src/lib/marble/geodata/data/GeoDataLatLonQuad.h a814f7f 
>   src/lib/marble/geodata/data/GeoDataLatLonQuad.cpp 4a29aac 
>   src/lib/marble/geodata/data/GeoDataLod.h e018d1a 
>   src/lib/marble/geodata/data/GeoDataLod.cpp a7c8506 
>   src/lib/marble/geodata/data/GeoDataRegion.h 936f3f4 
>   src/lib/marble/geodata/data/GeoDataRegion.cpp 57b74a0 
>   tests/TestEquality.cpp d32a771 
> 
> Diff: https://git.reviewboard.kde.org/r/116572/diff/
> 
> 
> Testing
> -------
> 
> Works perfectly here
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140305/27ed0b82/attachment.html>