[Marble-devel] Review Request 116553: Equality operators for GeoDataPoint, GeoDataLineString, GeoDataLinearRing, GeoDataPolygon

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116553/#review52111
-----------------------------------------------------------


This review has been submitted with commit b098a5cba497e59966b0e83ca7414eae33824072 by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.

- Commit Hook


On March 2, 2014, 10:41 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116553/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 10:41 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331672
>     http://bugs.kde.org/show_bug.cgi?id=331672
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Adds a protected method bool equals(GeoDataGeometry &other) const; to GeoDataGeometry and makes possible to check for equality using operator== for the classes mentioned in the Summary.
> Also added a testing function for each of the classes in tests/TestEquality.cpp and it passes all the tests.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataGeometry.h 0212a45 
>   src/lib/marble/geodata/data/GeoDataGeometry.cpp c09ba04 
>   src/lib/marble/geodata/data/GeoDataLineString.h b86fa07 
>   src/lib/marble/geodata/data/GeoDataLineString.cpp 3b60ed2 
>   src/lib/marble/geodata/data/GeoDataLinearRing.h 644dfd7 
>   src/lib/marble/geodata/data/GeoDataLinearRing.cpp b4fa3f5 
>   src/lib/marble/geodata/data/GeoDataPoint.h 1a61ca8 
>   src/lib/marble/geodata/data/GeoDataPoint.cpp aa595c0 
>   src/lib/marble/geodata/data/GeoDataPolygon.h c7071bf 
>   src/lib/marble/geodata/data/GeoDataPolygon.cpp 5007ab9 
>   tests/TestEquality.cpp d32a771 
> 
> Diff: https://git.reviewboard.kde.org/r/116553/diff/
> 
> 
> Testing
> -------
> 
> As I said above, I tested it using TestEquality and it works as expected.
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140305/6d5d4b34/attachment.html>