[Marble-devel] Review Request 116531: Equality operator for GeoDataTour and related classes

[Sanjiban Bairagya]

> On March 2, 2014, 5:23 p.m., Dennis Nienhüser wrote:
> > tests/TestEquality.cpp, line 397
> > <https://git.reviewboard.kde.org/r/116531/diff/5/?file=251453#file251453line397>
> >
> >     They must be equal at this point! It's important to write comparisons in test cases to assert what you *want* the object state to be like. It's tempting to assert instead what the current state is, but that relies on the assumption that the current code is correct and leads to severe errors slip by.
> 
> Sanjiban Bairagya wrote:
>     But aren't we already checking the "true" case in
>     QCOMPARE( tour1, tour1 );
>     QCOMPARE( tour2, tour2 );
> 
> Dennis Nienhüser wrote:
>     That just checks the trivial ones (equality to self). Missing is
>     QCOMPARE( tour1, tour2 );
>

Okay


- Sanjiban


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116531/#review51683
-----------------------------------------------------------


On March 2, 2014, 5:48 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116531/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 5:48 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331671
>     http://bugs.kde.org/show_bug.cgi?id=331671
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added operator== and operator!= to GeoDataAnimatedUpdate, GeoDataSoundCue, GeoDataTourControl, GeoDataWait, GeoDataPlaylist and GeoDataTour
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataAnimatedUpdate.h 420eebe 
>   src/lib/marble/geodata/data/GeoDataAnimatedUpdate.cpp 980e856 
>   src/lib/marble/geodata/data/GeoDataPlaylist.h d7ac52a 
>   src/lib/marble/geodata/data/GeoDataPlaylist.cpp d23175c 
>   src/lib/marble/geodata/data/GeoDataSoundCue.h 3029ff6 
>   src/lib/marble/geodata/data/GeoDataSoundCue.cpp 3507e96 
>   src/lib/marble/geodata/data/GeoDataTour.h 91ae5d7 
>   src/lib/marble/geodata/data/GeoDataTour.cpp d9567a6 
>   src/lib/marble/geodata/data/GeoDataTourControl.h e801bde 
>   src/lib/marble/geodata/data/GeoDataTourControl.cpp cc6b5cd 
>   src/lib/marble/geodata/data/GeoDataUpdate.h 2a376fd 
>   src/lib/marble/geodata/data/GeoDataUpdate.cpp a1650ca 
>   src/lib/marble/geodata/data/GeoDataWait.h 0d1bbcc 
>   src/lib/marble/geodata/data/GeoDataWait.cpp ce55704 
>   tests/TestEquality.cpp da98d4e 
> 
> Diff: https://git.reviewboard.kde.org/r/116531/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140302/bb812901/attachment-0001.html>