[Marble-devel] Review Request 116531: Equality operator for GeoDataTour and related classes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116531/#review51646
-----------------------------------------------------------



src/lib/marble/geodata/data/GeoDataAnimatedUpdate.h
<https://git.reviewboard.kde.org/r/116531/#comment36708>

    bool operator==( const GeoDataAnimatedUpdate &other) const;
    
    (+ const at the end)
    Same for all other ones and operator!=
    Same for some of the existing classes as well



src/lib/marble/geodata/data/GeoDataAnimatedUpdate.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36701>

    The '&' before m_update is wrong here. Please remove (and GeoDataUpdate needs an operator== as well)



src/lib/marble/geodata/data/GeoDataPlaylist.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36702>

    new line and curly brackets



src/lib/marble/geodata/data/GeoDataPlaylist.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36703>

    I'm missing the increment of index



src/lib/marble/geodata/data/GeoDataPlaylist.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36704>

    new line and curly brackets, same for the other ones below



src/lib/marble/geodata/data/GeoDataPlaylist.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36705>

    I'm missing the check for GeoDataFlyTo



src/lib/marble/geodata/data/GeoDataTourPrimitive.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36710>

    The patch lacks a change to the header where this method is introduced. I wonder if it is really needed though, GeoDataTourPrimitive is an abstract type that cannot be instantiated. I'd say neither the private class nor the .cpp are  needed, are they?
    



src/lib/marble/geodata/data/GeoDataTourPrimitive.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36706>

    No need for a private class here really. I'd remove it and just return GeoDataTypes::GeoDataTourPrimitiveType directly



src/lib/marble/geodata/data/GeoDataTourPrimitive.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36707>

    please remove pack and unpack, not needed and missing in the header



src/lib/marble/geodata/data/GeoDataWait.h
<https://git.reviewboard.kde.org/r/116531/#comment36709>

    const GeoDataWait &, same for operator!=



tests/TestEquality.cpp
<https://git.reviewboard.kde.org/r/116531/#comment36711>

    Can you check for more cases? Tours with different numbers of primitives, and same numbers of primitives where some are exchanged, ...


- Dennis Nienhüser


On March 2, 2014, 11:44 a.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116531/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 11:44 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Bugs: 331671
>     http://bugs.kde.org/show_bug.cgi?id=331671
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added operator== and operator!= to GeoDataAnimatedUpdate, GeoDataSoundCue, GeoDataTourControl, GeoDataWait, GeoDataPlaylist and GeoDataTour
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataAnimatedUpdate.h 420eebe 
>   src/lib/marble/geodata/data/GeoDataAnimatedUpdate.cpp 980e856 
>   src/lib/marble/geodata/data/GeoDataPlaylist.h d7ac52a 
>   src/lib/marble/geodata/data/GeoDataPlaylist.cpp d23175c 
>   src/lib/marble/geodata/data/GeoDataSoundCue.h 3029ff6 
>   src/lib/marble/geodata/data/GeoDataSoundCue.cpp 3507e96 
>   src/lib/marble/geodata/data/GeoDataTour.h 91ae5d7 
>   src/lib/marble/geodata/data/GeoDataTour.cpp d9567a6 
>   src/lib/marble/geodata/data/GeoDataTourControl.h e801bde 
>   src/lib/marble/geodata/data/GeoDataTourControl.cpp cc6b5cd 
>   src/lib/marble/geodata/data/GeoDataTourPrimitive.cpp PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataTourPrimitive_p.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataWait.h 0d1bbcc 
>   src/lib/marble/geodata/data/GeoDataWait.cpp ce55704 
>   src/lib/marble/geodata/parser/GeoDataTypes.h ae12cf1 
>   src/lib/marble/geodata/parser/GeoDataTypes.cpp a4c69e4 
>   tests/TestEquality.cpp 7a37b02 
> 
> Diff: https://git.reviewboard.kde.org/r/116531/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140302/287555b8/attachment.html>