[Marble-devel] Review Request 115938: Modified patch for bug 331369 - Code style fixes in QtMainWindow

[Dennis Nienhüser]

> On Feb. 26, 2014, 6:40 p.m., Dennis Nienhüser wrote:
> > This is the same diff as before, see https://git.reviewboard.kde.org/r/115938/diff/1-2/
> > You need to switch to the master branch locally (git checkout -b master origin/master) and fix any conflicts that arise. Then recreate the diff (against origin/master).
> >

Any news here? I wonder if I should accept one of the other patches for it.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115938/#review50970
-----------------------------------------------------------


On Feb. 26, 2014, 2:17 p.m., Savita Seetaraman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115938/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 2:17 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This is the patch for bug : 331369. It fixes code styles in src/apps/marble-qt/QtMainWindow.h and src/apps/marble-qt/QtMainWindow.cpp . 
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-qt/QtMainWindow.h 80ae250 
>   src/apps/marble-qt/QtMainWindow.cpp 750650a 
> 
> Diff: https://git.reviewboard.kde.org/r/115938/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Savita Seetaraman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140301/05b0a036/attachment.html>