[Marble-devel] Review Request 119022: Accept Create and Delete children tags in Update tags

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119022/#review61215
-----------------------------------------------------------



src/lib/marble/geodata/data/GeoDataUpdate.h
<https://git.reviewboard.kde.org/r/119022/#comment42638>

    Seems misplaced



src/lib/marble/geodata/data/GeoDataUpdate.h
<https://git.reviewboard.kde.org/r/119022/#comment42639>

    Lets go for getDelete here if delete conflicts with the keyword


- Dennis Nienhüser


On June 29, 2014, 8:09 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119022/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 8:09 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch adds support for accepting Create and Delete children tags in Update tags
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/CMakeLists.txt f6d4fb1 
>   src/lib/marble/geodata/data/GeoDataCreate.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataCreate.cpp PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataDelete.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataDelete.cpp PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataUpdate.h 59264d6 
>   src/lib/marble/geodata/data/GeoDataUpdate.cpp 3715661 
>   src/lib/marble/geodata/handlers/kml/KmlCreateTagHandler.h PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlCreateTagHandler.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlDeleteTagHandler.h PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlDeleteTagHandler.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlPlacemarkTagHandler.cpp 0e3d9a5 
>   src/lib/marble/geodata/parser/GeoDataTypes.h a94c141 
>   src/lib/marble/geodata/parser/GeoDataTypes.cpp 3bcb5f5 
>   src/lib/marble/geodata/writers/kml/KmlUpdateTagWriter.cpp 41b887f 
>   tests/data/Tour.kml 1df4ea4 
> 
> Diff: https://git.reviewboard.kde.org/r/119022/diff/
> 
> 
> Testing
> -------
> 
> Tested with tests/data/Tour.kml
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140629/1c07cc88/attachment.html>