[Marble-devel] Review Request 118943: Accept Placemarks as children of GeoDataChange

[Sanjiban Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118943/
-----------------------------------------------------------

(Updated June 26, 2014, 2:43 p.m.)


Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Changes
-------

Fixed GeoDataUpdate::operator==()


Repository: marble


Description
-------

This patch allows to accept Placemarks as children of GeoDataChange


Diffs (updated)
-----

  src/lib/marble/geodata/CMakeLists.txt bac40ac 
  src/lib/marble/geodata/data/GeoDataAnimatedUpdate.h 5794656 
  src/lib/marble/geodata/data/GeoDataAnimatedUpdate.cpp 511073c 
  src/lib/marble/geodata/data/GeoDataChange.h PRE-CREATION 
  src/lib/marble/geodata/data/GeoDataChange.cpp PRE-CREATION 
  src/lib/marble/geodata/data/GeoDataUpdate.h ddadee2 
  src/lib/marble/geodata/data/GeoDataUpdate.cpp ce42922 
  src/lib/marble/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp 9827969 
  src/lib/marble/geodata/handlers/kml/KmlChangeTagHandler.h PRE-CREATION 
  src/lib/marble/geodata/handlers/kml/KmlChangeTagHandler.cpp PRE-CREATION 
  src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.cpp 3a6bf5a 
  src/lib/marble/geodata/handlers/kml/KmlModelTagHandler.cpp fe2f126 
  src/lib/marble/geodata/handlers/kml/KmlPlacemarkTagHandler.cpp 110bc40 
  src/lib/marble/geodata/handlers/kml/KmlUpdateTagHandler.cpp 534749c 
  src/lib/marble/geodata/parser/GeoDataTypes.h dafcea3 
  src/lib/marble/geodata/parser/GeoDataTypes.cpp e87b876 
  src/lib/marble/geodata/writers/kml/KmlAnimatedUpdateTagWriter.h PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlAnimatedUpdateTagWriter.cpp PRE-CREATION 
  src/lib/marble/geodata/writers/kml/KmlLookAtTagWriter.cpp 4e45daa 
  src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp 86511bb 
  src/lib/marble/geodata/writers/kml/KmlPointTagWriter.cpp 70eadbc 
  src/lib/marble/geodata/writers/kml/KmlUpdateTagWriter.cpp fc1ddf6 
  tests/TestTour.cpp db2d9c9 
  tests/data/Tour.kml d9fc9ed 

Diff: https://git.reviewboard.kde.org/r/118943/diff/


Testing
-------

Tested and passed with tests/Tour.kml


Thanks,

Sanjiban Bairagya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140626/2e5bbb8f/attachment.html>