[Marble-devel] Review Request 118887: introduce docked placemark info widget

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118887/#review60833
-----------------------------------------------------------


I'd love to see a way for users to switch between both easily. E.g. having a "dock" button next to the close button of the popup item, which would close the popup and open the dock widget instead. Similarly a "float" button in the dock widget which would close the dock and open the popup item instead. I see two main advantages of that:
- we don't have to guess which one is more convenient to the user. The amount of information to show, the screen size, future user actions and other unknown things likely have an influence on whether the popup or the dock widget is better in a given situation.
- 3rd party library users get a default implementation (popup) easily without providing some additional widget. The "dock" button of the popup would have to be hidden in case there is no additional info widget provided for that to work properly.


- Dennis Nienhüser


On June 22, 2014, 7:54 p.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118887/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 7:54 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Viewing placemark information such as Wikipedia articles is currently done via a floating dialog. While it apprears quite
> stylish, it covers nearby items such that they can't be clicked or it is moved out of scope when the globe is rotated.
> These two properties of the floating dialog get in the way when exploring the world.
> 
> To improve the browsing experience, a dock widget containting a web view is used. In order to visually associate the view
> with an item, a thin line is drawn between them. This improves the browsing experience since the dock widget always remembers
> the last position and size no matter how the user scrolls around or clicks different items. It also doesn't cover nearby
> items. As a result, exploring Wikipedia articles and photos is much more addictive.
> 
> This patch is still work in progress. As such, it has of course issues such as the line being always drawn or the line not
> following the corner of the dock widget. Still, I want to get feedback if the general direction is right. Also, the dock
> widget should probably only be used for detailed placemark information, but not e.g. for balloon-style information. Note that
> even if I temporarily abused the PopupLayer to power the dock widget, I don't intend to remove PopupItem altogether (it could
> still show balloon-style information).
> 
> I'm looking forward to your feedback!
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-ui/ControlView.h cea9dc04926330222faaa8b729963a0bf7bba43c 
>   src/apps/marble-ui/ControlView.cpp 31294fc145b6244a0e1d1aa053a052f8dfdb947d 
>   src/lib/marble/MarbleWebView.h d564111586a25148a8391767c4f210e83f153951 
>   src/lib/marble/MarbleWebView.cpp b67a7fbc95642b93455c2f0717ac4b31d181e7af 
>   src/lib/marble/MarbleWidget.cpp d4c7ff48145bd55de23cf0a0e4a2b92e8037bb29 
>   src/lib/marble/MarbleWidgetPopupMenu.cpp 1dc7760903f4899e830d754957651c6681172971 
>   src/lib/marble/layers/PopupLayer.h ff18366c6b808f051cafa1ba3279f1f9b75c8109 
>   src/lib/marble/layers/PopupLayer.cpp 0bc58cd4f10f377e39fbf5b9ddfaafddccb60956 
> 
> Diff: https://git.reviewboard.kde.org/r/118887/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> docked info widget in action
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/f848fcc8-8324-49d9-b550-b420a6e7e074__PopupDock.png
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140623/7920ea1b/attachment.html>