[Marble-devel] Review Request 118868: Reading/Writing gx:balloonVisibility tags

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118868/#review60678
-----------------------------------------------------------

Ship it!



src/lib/marble/geodata/data/GeoDataPlacemark.cpp
<https://git.reviewboard.kde.org/r/118868/#comment42312>

    Must call detach(); first


- Dennis Nienhüser


On June 22, 2014, 1:40 a.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118868/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 1:40 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Adds support for reading/writing gx:balloonVisibility tags
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/CMakeLists.txt 0ec3c3b 
>   src/lib/marble/geodata/data/GeoDataPlacemark.h 6ca04ab 
>   src/lib/marble/geodata/data/GeoDataPlacemark.cpp 9422cde 
>   src/lib/marble/geodata/data/GeoDataPlacemark_p.h 033e9e2 
>   src/lib/marble/geodata/handlers/kml/KmlAnimatedUpdateTagHandler.h 815a1b9 
>   src/lib/marble/geodata/handlers/kml/KmlAnimatedUpdateTagHandler.cpp 3de5bac 
>   src/lib/marble/geodata/handlers/kml/KmlBalloonVisibilityTagHandler.h PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlBalloonVisibilityTagHandler.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h 01d8ad0 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp d8dfa76 
>   src/lib/marble/geodata/writers/kml/KmlPlacemarkTagWriter.cpp e2db3ca 
>   tests/data/NewYork.kml f118ecc 
> 
> Diff: https://git.reviewboard.kde.org/r/118868/diff/
> 
> 
> Testing
> -------
> 
> Tested on tests/data/New York.kml using TestGeoDataWriter, and it passed successfully
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140622/59f61ef1/attachment.html>