[Marble-devel] Review Request 118755: Refactors tour playback logic and adds basic interpolation of tours in Marble

Dennis Nienhüser earthwings at gentoo.org
Thu Jun 19 10:18:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118755/#review60487
-----------------------------------------------------------

Ship it!


Thanks, please commit :-)

One slight odd thing: The size of the pause icon is larger than the size of the other icons.

- Dennis Nienhüser


On June 19, 2014, 9:52 a.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118755/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 9:52 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch refactors tour playback logic and adds basic interpolation of tours in Marble
> 
> 
> Diffs
> -----
> 
>   src/apps/marble-ui/ControlView.cpp 84ed594 
>   src/lib/marble/CMakeLists.txt 4987c90 
>   src/lib/marble/ParallelTrack.h PRE-CREATION 
>   src/lib/marble/ParallelTrack.cpp PRE-CREATION 
>   src/lib/marble/PlaybackAnimatedUpdateItem.h PRE-CREATION 
>   src/lib/marble/PlaybackAnimatedUpdateItem.cpp PRE-CREATION 
>   src/lib/marble/PlaybackFlyToItem.h PRE-CREATION 
>   src/lib/marble/PlaybackFlyToItem.cpp PRE-CREATION 
>   src/lib/marble/PlaybackItem.h PRE-CREATION 
>   src/lib/marble/PlaybackItem.cpp PRE-CREATION 
>   src/lib/marble/PlaybackSoundCueItem.h PRE-CREATION 
>   src/lib/marble/PlaybackSoundCueItem.cpp PRE-CREATION 
>   src/lib/marble/PlaybackTourControlItem.h PRE-CREATION 
>   src/lib/marble/PlaybackTourControlItem.cpp PRE-CREATION 
>   src/lib/marble/PlaybackWaitItem.h PRE-CREATION 
>   src/lib/marble/PlaybackWaitItem.cpp PRE-CREATION 
>   src/lib/marble/SerialTrack.h PRE-CREATION 
>   src/lib/marble/SerialTrack.cpp PRE-CREATION 
>   src/lib/marble/TourPlayback.h 44a793f 
>   src/lib/marble/TourPlayback.cpp 03ab5f5 
>   src/lib/marble/TourWidget.h 31d3a59 
>   src/lib/marble/TourWidget.cpp 95d95b5 
>   src/lib/marble/TourWidget.ui 7a8a8ce 
>   src/lib/marble/geodata/data/GeoDataAbstractView.h 0f3f13c 
>   src/lib/marble/geodata/data/GeoDataAbstractView.cpp 32867ba 
> 
> Diff: https://git.reviewboard.kde.org/r/118755/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140619/7618e2c0/attachment.html>


More information about the Marble-devel mailing list