[Marble-devel] Review Request 118681: Add a thumbnailer for the supported geo data files (GPX, OSM, KML, ESRI)

[Friedrich W. H. Kossebau]

> On June 12, 2014, 2:09 a.m., Torsten Rahn wrote:
> > Wow, just wow :-)

"Just wow"? Too bad, I would also like a review ;)

Given that the features freeze is in almost a week, do you think we should try to get this in before? At least I would not mind if it does, think it is usable as it is already, and will be polished some more by me, once feedback is arriving.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118681/#review59844
-----------------------------------------------------------


On June 12, 2014, 12:33 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118681/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 12:33 a.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> As inspired by https://git.reviewboard.kde.org/r/118618/ I brushed up the thumbnailing code I drafted almost 2 years ago in the train on my way back from the Marble sprint in Prague. A shame I did not do that earlier.
> 
> It is another example where renderer state would be good to know. The current approach works more or less. Now and then no thumbnail is created, have yet to find out when this happens. And in the attached sample screenshot the New York KML files are for some reason not correctly zoomed in some thumbnails. Should be a useful testbed for the render status work. But IMHO good enough for a merge already.
> 
> The thumbnailer is only built in non-Qt-only mode. The service desktop files are installed for each geo data file type from the respective runner plugin sources, following the pattern of the App/KPart service desktop files.
> 
> Future improvements will be to make it configurable which map theme to use (now hardcoded to "earth/openstreetmap/openstreetmap.dgml"). Might get interesting for non-earth geo data files :) surely needs some more input from the experts.
> Not sure if thumbnails should be cached or not. Set it to "true" for now. Sadly this cannot be controlled case-by-case (e.g. if thumbnail has lower quality due to missing map theme data).
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt d7ea7b1 
>   src/plugins/runner/gpx/CMakeLists.txt 460c43a 
>   src/plugins/runner/gpx/marble_thumbnail_gpx.desktop PRE-CREATION 
>   src/plugins/runner/kml/CMakeLists.txt f964a85 
>   src/plugins/runner/kml/marble_thumbnail_kml.desktop PRE-CREATION 
>   src/plugins/runner/kml/marble_thumbnail_kmz.desktop PRE-CREATION 
>   src/plugins/runner/osm/CMakeLists.txt 392b2cf 
>   src/plugins/runner/osm/marble_thumbnail_osm.desktop PRE-CREATION 
>   src/plugins/runner/shp/CMakeLists.txt ccc0c9d 
>   src/plugins/runner/shp/marble_thumbnail_shp.desktop PRE-CREATION 
>   src/thumbnailer/CMakeLists.txt PRE-CREATION 
>   src/thumbnailer/main.cpp PRE-CREATION 
>   src/thumbnailer/thumbnailer.h PRE-CREATION 
>   src/thumbnailer/thumbnailer.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118681/diff/
> 
> 
> Testing
> -------
> 
> Enabled previews for the geo data files (Dolphin > Preferences > General > Previews) and browsed all kind of folders with geo data files.
> 
> To get rid of cached thumbnails do "rm ~/.thumbnails/ -r" or set CacheThumbnail=false in the desktop service files.
> 
> 
> File Attachments
> ----------------
> 
> Thumbnails in KML example folder
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/12/5503799d-318e-45d7-856c-6d505d8c95c6__thumbnails.png
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140617/3fcfb41c/attachment.html>