[Marble-devel] Review Request 118766: Customization option for drawn polygons

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118766/#review60189
-----------------------------------------------------------


Some UI thoughts since you asked for them in your blog :)
- what about using the ShowAlphaChannel option of QColorDialog instead of having an additional slider?
- the color selection controls could be merged into something like this
  Fill Color: [drop down or list view with entries]
    * No Color
    * some blue color (from oxygen palette)
    * some red color (from oxygen palette)
    * some purple color (from oxygen palette)
    * ...
    * custom color (triggers color dialog)
- it might be nice to use a modeless dialog (non blocking, use open() instead of exec()) with an Apply button so the user can leave the dialog open toggle through the options quickly


- Dennis Nienhüser


On June 15, 2014, 6:51 p.m., Cruceru Calin-Cristian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118766/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 6:51 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I added a pretty simple customization option for drawn polygons which includes the following:
> - polygon area/lines color and opacity modifying;
> - lines width modifying;
> - polygon area filling can be set to "Not Filled".
> 
> Waiting for suggestions on what else would be nice to have as well as remarks about this implementation.
> 
> PS: It is what I have been working on for the last two days, so there is not too much code, but I think it is better than submitting large patches as I did last time.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.h a401714 
>   src/plugins/render/annotate/AnnotatePlugin.cpp 2aca70e 
>   src/plugins/render/annotate/AreaAnnotation.cpp 1a4452b 
>   src/plugins/render/annotate/CMakeLists.txt 6caa034 
>   src/plugins/render/annotate/EditGroundOverlayDialog.ui 9873e8c 
>   src/plugins/render/annotate/EditPolygonDialog.h PRE-CREATION 
>   src/plugins/render/annotate/EditPolygonDialog.cpp PRE-CREATION 
>   src/plugins/render/annotate/EditPolygonDialog.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118766/diff/
> 
> 
> Testing
> -------
> 
> It works very nice.
> 
> 
> Thanks,
> 
> Cruceru Calin-Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140616/247bb744/attachment.html>