[Marble-devel] [SOLVED] Re: Review Request 118495: Marble input handling refactor. Support for mouse, touch and pinch in MarbleQuickItem.

[Friedrich W. H. Kossebau]

Am Donnerstag, 5. Juni 2014, 19:22:42 schrieb Friedrich W. H. Kossebau:
> Am Dienstag, 3. Juni 2014, 11:49:04 schrieb Adam Dabrowski:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/118495/
> > -----------------------------------------------------------
> > 
> > Review request for Marble.
> > 
> > 
> > Repository: marble
> > 
> > 
> > Description
> > -------
> > 
> > Functionalities:
> > - Mouse, touch and pinch input handling for MarbleQuickItem (keyboard was
> > enabled earlier)
> > 
> > Other changes:
> > - Refactored input handling to reuse code, broke into smaller pieces
> > (functions) - Extended the example (marbleQuick2)
> > 
> > Known issues:
> > - Some refactoring still should be done around input classes
> > - Inertial rotation is disabled by default in MarbleQuickItem because of
> > some issues (mostly touch-related). However, issues are rather minor so
> > feel free to enable it back.
> 
> This API change sadly broke at least the Calligra build on build.kde.org. At
> least the code which uses Marble like this:
> https://projects.kde.org/projects/calligra/repository/revisions/master/entry
> /plugins/semanticitems/location/KoRdfLocationEditWidget.cpp#L80
> 
> How should that best be changed to work with the new API? And which
> MARBLE_VERSION to check against?

Thanks Adam and Dennis for the help. Based on a patch proposed by Dennis, 
which drops the use of any Inputhandler, instead using just the 
visibleLatLonAltBoxChanged signal, the problem has been successfully resolved.

Builds locally for me (older Marble of 4.11.5), and also on build.kde.org 
already flawlessly passed the spot where it fell before due to the latest API 
:)

Cheers
Friedrich