[Marble-devel] Marble-devel Digest, Vol 82, Issue 6

[adamdabr]

Hi Friedrich

Marble::MarbleWidgetDefaultInputHandler class no longer exists. It has been replaced with Marble:MarbleWidgetInputHandler as a part of the refactoring process.
You shouldn't need to create the input handler. Just create the MarbleWidget as usual and then use inputHandler() public function to get this widget input handler (it's enough to use MarbleInputHandler * abstract pointer for it) and connect it to signals that you need.

Hope that helps,
Adam

> ----------------------------------------------------------------------
> 
> Message: 1
> Date: Thu, 05 Jun 2014 19:22:42 +0200
> From: "Friedrich W. H. Kossebau" <kossebau at kde.org>
> To: marble-devel at kde.org
> Cc: calligra-devel at kde.org
> Subject: Re: [Marble-devel] Review Request 118495: Marble input
> 	handling	refactor. Support for mouse, touch and pinch in
> 	MarbleQuickItem.
> Message-ID: <1415409.NeeTWHfoGk at klux.site>
> Content-Type: text/plain; charset="us-ascii"
> 
> Hi,
> 
> (cc: to calligra-devel just for heads-up, please remove when replying)
> 
> Am Dienstag, 3. Juni 2014, 11:49:04 schrieb Adam Dabrowski:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/118495/
> > -----------------------------------------------------------
> > 
> > Review request for Marble.
> > 
> > 
> > Repository: marble
> > 
> > 
> > Description

W dniu 2014-06-06 09:10:07 użytkownik  <marble-devel-request at kde.org> napisał:
> Send Marble-devel mailing list submissions to
> 	marble-devel at kde.org
> 
> To subscribe or unsubscribe via the World Wide Web, visit
> 	https://mail.kde.org/mailman/listinfo/marble-devel
> or, via email, send a message with subject or body 'help' to
> 	marble-devel-request at kde.org
> 
> You can reach the person managing the list at
> 	marble-devel-owner at kde.org
> 
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Marble-devel digest..."
> 
> 
> Today's Topics:
> 
>    1. Re: Review Request 118495: Marble input handling	refactor.
>       Support for mouse, touch and pinch in MarbleQuickItem.
>       (Friedrich W. H. Kossebau)
>    2. Review Request 118572: Added 'highlight on click'	feature
>       (Abhinav Gangwar)
>    3. Re: Review Request 118405: Added polygon moving/node
>       deletion/drawing polygon holes features to annotate plugin
>       (Torsten Rahn)
>    4. Re: Review Request 118405: Added polygon moving/node
>       deletion/drawing polygon holes features to annotate plugin
>       (Commit Hook)
> 
> 
> > -------
> > 
> > Functionalities:
> > - Mouse, touch and pinch input handling for MarbleQuickItem (keyboard was
> > enabled earlier)
> > 
> > Other changes:
> > - Refactored input handling to reuse code, broke into smaller pieces
> > (functions) - Extended the example (marbleQuick2)
> > 
> > Known issues:
> > - Some refactoring still should be done around input classes
> > - Inertial rotation is disabled by default in MarbleQuickItem because of
> > some issues (mostly touch-related). However, issues are rather minor so
> > feel free to enable it back.
> 
> This API change sadly broke at least the Calligra build on build.kde.org. At 
> least the code which uses Marble like this:
> https://projects.kde.org/projects/calligra/repository/revisions/master/entry/plugins/semanticitems/location/KoRdfLocationEditWidget.cpp#L80
> 
> How should that best be changed to work with the new API? And which 
> MARBLE_VERSION to check against?
> 
> Cheers
> Friedrich
> 
>