[Marble-devel] Review Request 119273: Shows AnimatedUpdate items in TourWidget's view

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119273/#review62299
-----------------------------------------------------------



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/119273/#comment43287>

    Missing tr(). Also the case where all are missing is not handled nicely, results in plain " items" string. Finally there's an assumption that the grammar of the to be translated language follows the english one, which will not be the case always. Let's simplify it further to a plain tr( "Update items" ) call for any case.



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/119273/#comment43288>

    will the edit button be disabled?


- Dennis Nienhüser


On July 14, 2014, 2:33 p.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119273/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 2:33 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> This patch shows AnimatedUpdate items in the TourWidget's list-view
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/PlaybackAnimatedUpdateItem.cpp a4d2680 
>   src/lib/marble/TourWidget.cpp 20a2ecf 
> 
> Diff: https://git.reviewboard.kde.org/r/119273/diff/
> 
> 
> Testing
> -------
> 
> Tested with the example tour in the moon's legend. Works fine there
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140714/16cf0166/attachment.html>