[Marble-devel] Review Request 118620: In Pn2Runner handle the case when placemark geometry is multigeometry.

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118620/#review62178
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Juli 9, 2014, 7:43 vorm., Abhinav Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118620/
> -----------------------------------------------------------
> 
> (Updated Juli 9, 2014, 7:43 vorm.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Modified Pn2Runner and added an 'if' case to handle MULTIGEOMETRY.
> Changed version no. of pn2 format to 2 and added suuport to parse previous versions of pn2 format.
> Modified shp2pn2 so that it now writes placemarkID also to pn2 file.
> 
> 
> Diffs
> -----
> 
>   data/naturalearth/ne_50m_admin_0_boundary_lines_land.pn2 f01c4cd2085b9e28e412f9497bf835a871a6dfe1 
>   data/naturalearth/ne_50m_admin_0_boundary_lines_maritime_indicator.pn2 029a94e42b5e6e0936461087721602d0ea4dad7d 
>   data/naturalearth/ne_50m_admin_0_breakaway_disputed_areas.pn2 22a9b648ea878aaf1960ef41e9cc2f228cc0005c 
>   data/naturalearth/ne_50m_admin_0_countries.pn2 a982356149bdc512a7d45de7bf88892371a36efe 
>   data/naturalearth/ne_50m_admin_0_pacific_groupings.pn2 4e3146a70c1d7b8b539d2bdc1f15b94e19538fb8 
>   data/naturalearth/ne_50m_admin_1_states_provinces_lines.pn2 3e8120767321f9985bc142baa7ead592931cfc22 
>   data/naturalearth/ne_50m_antarctic_ice_shelves_lines.pn2 b18610c83fd7ea326badf6ad9f0faaea295b96d8 
>   data/naturalearth/ne_50m_antarctic_ice_shelves_polys.pn2 f45940f49d56656222091d7e03d97f31a824ca6c 
>   data/naturalearth/ne_50m_coastline.pn2 1c1326e8b9e3443c86e41cff6b308080328b18c9 
>   data/naturalearth/ne_50m_glaciated_areas.pn2 6112136db5069f9e203580ab58a4cf89cc7db1e4 
>   src/plugins/runner/pn2/Pn2Runner.h 520b367 
>   src/plugins/runner/pn2/Pn2Runner.cpp 74fa848 
>   src/plugins/runner/shp/ShpRunner.cpp b472d44 
>   tools/shp2pn2/shp2pn2.cpp 639b30f 
>   data/naturalearth/ne_50m_playas.pn2 f1abfe0e9550f2b583c4e0e8b860134bec2dbe18 
>   data/naturalearth/ne_50m_rivers_lake_centerlines.pn2 05b91faab53bed5bb39fc8b3a234c3c97c4f22d2 
>   data/naturalearth/ne_50m_urban_areas.pn2 fbfb15a74e5e63699c703e0e0b04a6ff0ca32fad 
>   data/naturalearth/ne_50m_lakes.pn2 e30a90e1455544e27e2983f74109d313067399aa 
>   data/naturalearth/ne_50m_lakes_historic.pn2 2ac5be68c3d2aa96a19a68f9a720832374da1329 
>   data/naturalearth/ne_50m_land.pn2 67baf68c3d52419135d9f8f0de38fde6d5d406a6 
>   data/naturalearth/ne_10m_rivers_lake_centerlines.pn2 01c764c69ec35d146eb6525395991055a720961b 
>   data/naturalearth/ne_10m_admin_0_boundary_lines_land.pn2 37d403392119db84996a38a86dd4854ca3b4dd99 
> 
> Diff: https://git.reviewboard.kde.org/r/118620/diff/
> 
> 
> Testing
> -------
> 
> works fine here.
> 
> 
> Thanks,
> 
> Abhinav Gangwar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140712/6096f836/attachment.html>