[Marble-devel] Review Request 118572: Added 'highlight on click' feature

[Abhinav Gangwar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118572/
-----------------------------------------------------------

(Updated July 9, 2014, 2:47 p.m.)


Status
------

This change has been discarded.


Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Repository: marble


Description
-------

Implements 'highlight on click' feature
  -- Added a new class HighLightPolygon which is responsible for highlighting ( and also restoring the normal style ) polygon.
  -- Added signal mouseClickGeoPosition() in MarbleInputHandler which works on same logic as the triggering of left mouse
     button pop up info dialog.
  -- Added a HighlightPolygon member in MarbleWidget and added getter and setter for it and a method setHighlightEnabled.

Every thing is fine except that to see the polygon colored highlighted after it has been applied the highlighted style, I have
to first unselect and the select the file again from files panel. I am triggering MarbleWidget::update() but it's not done. So
I need help here. 

And of course we can change the names of methods or class if they are not suitable.


Diffs
-----

  src/lib/marble/CMakeLists.txt 395e8bf 
  src/lib/marble/HighlightPolygon.h PRE-CREATION 
  src/lib/marble/HighlightPolygon.cpp PRE-CREATION 
  src/lib/marble/MarbleInputHandler.h 58107e5 
  src/lib/marble/MarbleInputHandler.cpp 3fce19a 
  src/lib/marble/MarbleModel.h 9643186 
  src/lib/marble/MarbleModel.cpp 2c56476 
  src/lib/marble/MarbleWidget.h e8148a9 
  src/lib/marble/MarbleWidget.cpp d58db8e 

Diff: https://git.reviewboard.kde.org/r/118572/diff/


Testing
-------

Works fine here :-)


Thanks,

Abhinav Gangwar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140709/0b611669/attachment.html>