[Marble-devel] Review Request 119097: A fix for Qt "file not found warnings" originating in TileLoader

Dennis Nienhüser earthwings at gentoo.org
Thu Jul 3 08:51:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119097/#review61529
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On July 3, 2014, 6:43 a.m., Adam Dabrowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119097/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 6:43 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> A simple fix for Qt warnings from constructor of QImage. When created with a filename argument, QImage tries to open file and produces warning when it is not successful (at least in Qt 5.3).
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TileLoader.cpp 8dc568e 
> 
> Diff: https://git.reviewboard.kde.org/r/119097/diff/
> 
> 
> Testing
> -------
> 
> ran application with custom texture (gdal-generated tiles for levels 10-18: warnings were spammed for each missing level before, clean now).
> 
> 
> Thanks,
> 
> Adam Dabrowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140703/91353b13/attachment.html>


More information about the Marble-devel mailing list