[Marble-devel] Review Request 114082: Added combobox support to the Marble Legend Browser

[Yazeed Zoabi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114082/
-----------------------------------------------------------

(Updated Jan. 19, 2014, 12:31 p.m.)


Status
------

This change has been discarded.


Review request for Marble, Utku Aydın, Dennis Nienhüser, and Torsten Rahn.


Repository: marble


Description
-------

You can now use add comboboxes in maps.

In order to use this feature, new attributes to sections are introduced: combobox, comboboxOrder.
the comboboxOrder attribute should appear twice, once to indicate that top of a combobox, and the other to indicate it's bottom :D. (top: "first", middle: [anything but first or last], bottom: "last")

note: You must keep checkable="true" (one reason for that is for options to function as checkboxes in older versions of marble)

Example:

	      <section name="first" checkable="true" comboBox="true" comboBoxOrder="first" connect="first" spacing="12">
		  <heading>First option</heading>
	      </section>
	      <section name="middle" checkable="true" comboBox="true" comboBoxOrder="" connect="middle" spacing="12">
		  <heading>Middle option</heading>
	      </section>
	      <section name="last" checkable="true" comboBox="true" comboBoxOrder="last" connect="last" spacing="12">
		  <heading>Last option</heading>
	      </section>

merged in : https://git.reviewboard.kde.org/r/114144/


Diffs
-----

  src/lib/marble/MarbleLegendBrowser.h e7fb4b5 
  src/lib/marble/MarbleLegendBrowser.cpp 644dd0f 
  src/lib/marble/geodata/handlers/DgmlOptionTagHandler.h e69de29 
  src/lib/marble/geodata/handlers/DgmlOptionTagHandler.cpp e69de29 
  src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.h d426e0d 
  src/lib/marble/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 20b0ebe 
  src/lib/marble/geodata/handlers/dgml/DgmlSectionTagHandler.cpp 66ee562 
  src/lib/marble/geodata/parser/GeoSceneTypes.h 5fd1cdb 
  src/lib/marble/geodata/parser/GeoSceneTypes.cpp a653d02 
  src/lib/marble/geodata/scene/GeoSceneOption.h e69de29 
  src/lib/marble/geodata/scene/GeoSceneOption.cpp e69de29 
  src/lib/marble/geodata/scene/GeoSceneSection.h 5224f43 
  src/lib/marble/geodata/scene/GeoSceneSection.cpp 9d7bf77 

Diff: https://git.reviewboard.kde.org/r/114082/diff/


Testing
-------

Kubuntu 13.10 . Qt version:  4.8.4 .


File Attachments
----------------

snapshot4.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/2930e2e7-a1e9-46f5-b84e-ba69ec7aa184__snapshot4.png
snapshot5.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/804f61ea-5802-4c44-b099-cb830771c8e9__snapshot5.png
snapshot6.png
  https://git.reviewboard.kde.org/media/uploaded/files/2013/11/25/d7e5fe3e-7fe6-4aaa-8341-fd4b0fe63a41__snapshot6.png


Thanks,

Yazeed Zoabi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140119/9922965b/attachment-0001.html>