[Marble-devel] Review Request 114853: Use QPointer for dialog exec as identified by krazy

Danny Rim utf8snowman+2 at gmail.com
Wed Jan 15 19:24:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114853/
-----------------------------------------------------------

(Updated Jan. 15, 2014, 7:24 p.m.)


Review request for Marble and Dennis Nienhüser.


Changes
-------

Add marble group as reviewer


Repository: marble


Description
-------

Use QPointer for dialog exec as identified by krazy

dlg renamed to dialog

GCI task http://www.google-melange.com/gci/task/view/google/gci2013/5855967858130944


Diffs
-----

  src/apps/marble-kde/marble_part.cpp 497842a 
  src/apps/marble-mobile/MobileMainWindow.cpp 751f4df 
  src/lib/marble/BookmarkManagerDialog.cpp a67b099 
  src/lib/marble/MapWizard.cpp 235f9df 
  src/lib/marble/MarbleWidget.cpp ef0479e 
  src/lib/marble/MarbleWidgetPopupMenu.cpp e527bdf 
  src/lib/marble/TourWidget.cpp 12c42da 
  src/lib/marble/routing/RoutingManager.cpp 013e392 
  src/lib/marble/routing/RoutingWidget.cpp 4a83d34 
  src/plugins/render/fileview/FileViewFloatItem.cpp ae6e1ba 

Diff: https://git.reviewboard.kde.org/r/114853/diff/


Testing
-------

Builds successfully, works


Thanks,

Danny Rim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20140115/dc5073ca/attachment.html>


More information about the Marble-devel mailing list